View your CI Pipeline Execution ↗ for commit cc883c4

☁️ Nx Cloud last updated this comment at 2025-09-30 12:39:10 UTC

npm i https://pkg.pr.new/@tanstack/angular-form@1697

npm i https://pkg.pr.new/@tanstack/form-core@1697

npm i https://pkg.pr.new/@tanstack/form-devtools@1697

npm i https://pkg.pr.new/@tanstack/lit-form@1697

npm i https://pkg.pr.new/@tanstack/react-form@1697

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1697

npm i https://pkg.pr.new/@tanstack/solid-form@1697

npm i https://pkg.pr.new/@tanstack/svelte-form@1697

npm i https://pkg.pr.new/@tanstack/vue-form@1697

commit: cc883c4

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.48%. Comparing base (6892ed0) to head (cc883c4).
⚠️ Report is 21 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
+ Coverage   90.35%   90.48%   +0.12%     
==========================================
  Files          38       38              
  Lines        1752     1786      +34     
  Branches      444      451       +7     
==========================================
+ Hits         1583     1616      +33     
- Misses        149      150       +1     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kusiewicz It happens before the submit validation, but only in cases where canSubmit is false. That means there are currently errors present that have not been resolved, which is not stale.

If a user wanted to rerun validators even if canSubmit is false, they can use the canSubmitWhenInvalid property

@kusiewicz It happens before the submit validation, but only in cases where canSubmit is false. That means there are currently errors present that have not been resolved, which is not stale.

If a user wanted to rerun validators even if canSubmit is false, they can use the canSubmitWhenInvalid property

Ok i got it. I just thought that there:

  onSubmitInvalid: ({ formApi }) => {
    console.log(formApi.state.fieldMeta.xxx.errors);
  }

we should expect most recent errors, didn't know about canSubmitWhenInvalid

well, they are the most recent errors. The most recent errors are preventing a submit altogether, so this PR asserts that attempting one should still trigger onSubmitInvalid

Hello @Pascalmh!

I encountered the same issue mentioned by @kusiewicz. Calling onSubmitInvalid before performing validation may result in outdated error states being passed to the callback.

Would you consider restructuring the logic to first perform the validation, check canSubmit, and then call onSubmitInvalid with the updated state? In this case, the user would receive the most recent validation error in the callback.

If it's okay with you, would it be possible for me to work on this and submit a PR?

@jiji-hoon96 sure, if you want you can PR against my fork and I'll merge your changes in so they appear in this PR here - or you can create a new PR, whatever you prefere 👍

@jiji-hoon96 Are you sure it's stale? Even with canSubmitWhenInvalid: true?

Yes. I have confirmed its validity through testing. I may have made a mistake, so I would appreciate it if you could take a look at #1711 PR.

Pascalmh#5

I have submitted a pull request with some modifications to @Pascalmh`s work.

🦋 Changeset detected

Latest commit: cc883c4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This has been long overdue. Thanks for the fix!